Convert tilesets.s to C #1796
Merged
Convert tilesets.s to C #1796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Porymap doesn't currently support this (working on that now). The plan is to keep supporting the old assembly format, so downstream conversion won't be necessary, but if someone would like to automate this feel free to provide a script. (Porymap could convert between the two data formats, but seeing as it can't automate the rest of the necessary changes I'm not sure that's a good idea).
The primary benefit of converting these to C is that changes to the
Tilesetstruct will be enforced on the tileset header file, e.g. if someone adds a new field toTilesetit will be automatically included in every header, as opposed to having to manually update the file.