Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #143

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented May 18, 2023

Builds correctly with ghc-9.6.1

Would also love to see a new release (or a Hackage revision) with these changes.

These changes will allow us to drop a bunch of allow-newer stanzas in the cabal.project file of our ghc-9.6 builds.

@erikd
Copy link
Contributor Author

erikd commented May 18, 2023

I would also be happy to become a project collaborator for protolude if you want me. I work for IOHK/IOG and we use protolude at the bottom of our software stack.

Builds correctly with ghc-9.6.1
@erikd erikd force-pushed the erikd/update-dependencies branch from 7888eba to 26302de Compare May 18, 2023 22:35
@erikd
Copy link
Contributor Author

erikd commented May 21, 2023

It is possible to relax these constraints using a package revision on Hackage.

@andreasabel
Copy link

@adamwespiser CI needs your intervention to run on this PR, it seems.

@erikd
Copy link
Contributor Author

erikd commented Jun 12, 2023

@andreasabel Is this not suitable for a Hackage trustee metadata edit now?

@@ -67,17 +68,17 @@ library
build-depends:
array >=0.4 && <0.6
, async >=2.0 && <2.3
, base >=4.6 && <4.18
, base >=4.6 && <4.20

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be <4.19.

, bytestring >=0.10 && <0.12
, containers >=0.5 && <0.7
, containers >=0.5 && <0.8

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the last containers 0.6.7 ?

@andreasabel
Copy link

@andreasabel Is this not suitable for a Hackage trustee metadata edit now?

Here you go: https://hackage.haskell.org/package/protolude-0.3.3/revisions/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants