Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add progress bar to TracInCPFastRandProj.__init__ #899

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

99warriors
Copy link
Contributor

Summary:

  • adds progress bar for computation done in TracInCPFastRandProj.__init__, as well as a show_progress argument
  • actual computation is done in TracInCPFastRandProj._get_intermediate_quantities_tracincp_fast_rand_proj. This method is changed so that the outer loop is over training batches (as opposed to over checkpoints), so that it is actually possible to report how many batches have been processed.
  • add a new "mode" to test_tracin_show_progress and use it to test.

Differential Revision: D34803544

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34803544

Summary:
Pull Request resolved: pytorch#898

- add progress bar to all computations involving iterating over all batches in the training data
- add test, but only for case where `influence_src_dataloader` implements `len`

Differential Revision: D34776754

fbshipit-source-id: ebd98aaf11390bac0b2b513512f5c07d593773dd
Summary:
Pull Request resolved: pytorch#899

- adds progress bar for computation done in `TracInCPFastRandProj.__init__`, as well as a `show_progress` argument
- actual computation is done in `TracInCPFastRandProj._get_intermediate_quantities_tracincp_fast_rand_proj`.  This method is changed so that the outer loop is over training batches (as opposed to over checkpoints), so that it is actually possible to report how many batches have been processed.
- add a new "mode" to `test_tracin_show_progress` and use it to test.

Differential Revision: D34803544

fbshipit-source-id: 3be88d853361139aa2e8199eec6ec9bb1f340902
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D34803544

@facebook-github-bot
Copy link
Contributor

Hi @99warriors!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants