-
Notifications
You must be signed in to change notification settings - Fork 21.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow overriding per-dim group options via _MeshEnv.set_dim_group_options #126599
Open
yifuwang
wants to merge
16
commits into
gh/yifuwang/85/base
Choose a base branch
from
gh/yifuwang/85/head
base: gh/yifuwang/85/base
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+35
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced May 18, 2024
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126599
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (3 Unrelated Failures)As of commit a96de27 with merge base 4afc5c7 (): FLAKY - The following job failed but was likely due to flakiness present on trunk:
UNSTABLE - The following jobs failed but were likely due to flakiness present on trunk and has been marked as unstable:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
oncall: distributed
Add this issue/PR to distributed oncall triage queue
label
May 18, 2024
yifuwang
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: 3affd43fbf799cc2888289225d36347409d5c3dc Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: b20313fee3f27ad5104290d6a5a44fa4e52d30aa Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 18, 2024
ghstack-source-id: 36f90cd502058de8b4278a5f6eb42c638502d9f0 Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 19, 2024
ghstack-source-id: ff49b96912ec614b91df08ec4478f5c4bd881cd6 Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 19, 2024
ghstack-source-id: ff49b96912ec614b91df08ec4478f5c4bd881cd6 Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 20, 2024
ghstack-source-id: 5b2dae763f7d1810f08467f839c64a20e872623c Pull Request resolved: #126599
wanchaol
reviewed
May 21, 2024
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 21, 2024
ghstack-source-id: 651c4bf12ced6104c72eea1c4719d8e16475fdae Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 21, 2024
ghstack-source-id: 651c4bf12ced6104c72eea1c4719d8e16475fdae Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 21, 2024
ghstack-source-id: 8ab9ab99138eeb16a242fb63d33e06ed77344e9a Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 22, 2024
ghstack-source-id: dfb90df6f9eab666c9e65d673b74bafee2736dfd Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
yifuwang
added a commit
that referenced
this pull request
May 24, 2024
ghstack-source-id: 0324a1947296112e37469d64138cffe6285ee644 Pull Request resolved: #126599
cc mrshenli pritamdamania87 zhaojuanmao satgera gqchen aazzolini osalpekar jiayisuse H-Huang kwen2501 awgu penguinwu fegin XilunWu wanchaol fduwjj wz337 tianyu-l wconstab yf225 chauhang d4l3k [ghstack-poisoned]
…m_group_options" [ghstack-poisoned]
yifuwang
changed the title
[WIP] _set_mesh_dim_group_options
Allow overriding per-dim group options via _MeshEnv.set_dim_group_options
May 29, 2024
…m_group_options" [ghstack-poisoned]
…m_group_options" [ghstack-poisoned]
…m_group_options" [ghstack-poisoned]
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):