C++/CMake / Only link gcc_s library when making a shared library build (caffe only) #126621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/126621
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 615423f with merge base 173b1d8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Sounds convincing. |
drisspg
added
the
triaged
|
Does this change make sense ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are making a static build of libtorch for a static executable, and this is getting in our way.
The link fails with "gcc_s not found". I just found out that the _s version of libgcc is a shared library, so we can't bring in in a static build.
This fix just add a conditional to bring in gcc_s. The existing code only affect the caffe build.
cc @malfet @seemethere