Clean __contains__ #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raamana
reviewed
Aug 29, 2017
| else: | ||
| return False | ||
| """Boolean test of membership of a sample in the dataset.""" | ||
| return item in self.keys |
There was a problem hiding this comment.
Hey Scott, thanks for the PR. For a simple test, the suggested code is certainly more compact. However, I planned to add more functionality for [non-]membership, in case of multiple items or a more complex test (e.g. missing data). I should perhaps add a note or TODO here to reflect that.
There was a problem hiding this comment.
What more complex test would you add? Isn't missing data not contained in the dataset?
There was a problem hiding this comment.
For example, when the missing data is partial, or data is not of certain type across all subjects. I'm still thinking through other use cases, though. But thanks for the suggestion to compactify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.