Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rails is not Django #1

Closed
leah opened this issue Apr 1, 2009 · 11 comments
Closed

Rails is not Django #1

leah opened this issue Apr 1, 2009 · 11 comments

Comments

@leah
Copy link

leah commented Apr 1, 2009

I have an issue with this.
@AbeEstrada
Copy link

That is a big issue.

@dodeja
Copy link

dodeja commented Apr 16, 2009

This is a problem.

@boblmartens
Copy link

I’m glad it isn’t.

@nofxx
Copy link

nofxx commented Apr 17, 2009

I`m sure someone is working on a fix.

@rabble
Copy link

rabble commented Apr 17, 2009

Please don’t fix.

@mattly
Copy link

mattly commented Apr 17, 2009

-1 please don’t fix. don’t you python people have anything better to do? like scoop up pony power poop?

@dmathieu
Copy link
Contributor

Djan What ? How do you even pronounce it ??

@botanicus
Copy link

Here is the fix: http://github.com/botanicus/rango/tree/master

@tazsingh tazsingh mentioned this issue Nov 22, 2011
Closed
@jaylevitt jaylevitt mentioned this issue Dec 7, 2011
Closed
@jrochkind jrochkind mentioned this issue Jan 25, 2012
Closed
@mmell mmell mentioned this issue Mar 10, 2012
Closed
@iamjoshua iamjoshua mentioned this issue Mar 13, 2012
Closed
@austinthecoder austinthecoder mentioned this issue Apr 9, 2012
Closed
@Sephi-Chan Sephi-Chan mentioned this issue Apr 28, 2012
Closed
@steveklabnik steveklabnik mentioned this issue Jun 7, 2012
Closed
@uberbrady uberbrady mentioned this issue Jul 9, 2012
Closed
@chancancode chancancode mentioned this issue Jul 19, 2012
Closed
@luke-gru luke-gru mentioned this issue Nov 9, 2012
Merged
@jredburn jredburn mentioned this issue Dec 5, 2012
Closed
@archonic
Copy link

archonic commented Jan 2, 2013

lulz

@josemotanet josemotanet mentioned this issue Jan 14, 2013
Closed
joergschray added a commit to tandem-softworks/rails that referenced this issue Apr 27, 2013
@joergschray
Issue rails#1: :before_add callback is called when nested attributes …
1eced51 
…assignment assigns to existing record if the association is not yet loaded

Issue rails#2: Nested Attributes assignment does not affect the record in the association target when callback triggers loading of the association

Complete rewrite of tests
@bughit bughit mentioned this issue Nov 9, 2013
Closed
@tenderlove tenderlove mentioned this issue Nov 25, 2013
Closed
kbrock pushed a commit to kbrock/rails that referenced this issue Dec 23, 2013
@jrafanie
Merge pull request rails#1 from lfu/eager_loading_1018392
1ca8b5e 
Fix an issue with where clause with a dot character.
mislav pushed a commit to mislav/rails that referenced this issue Jan 9, 2014
@atmos
Merge pull request rails#1 from github/cve-2013-0333
0ad8634 
Backport Patches for CVE-2013-0333
@terracatta terracatta mentioned this issue Jan 21, 2014
Closed
glinesbdev referenced this issue Jul 25, 2014
@vipulnsward
update copyright notices to 2014. [ci skip]
98cb3e6
seuros referenced this issue in seuros/django Aug 12, 2014
@dhh
Merge pull request #1 from charliesome/patch-1
ce124a1 
Clean up JobWrappers::ResqueWrapper.perform
@dhh dhh mentioned this issue Aug 16, 2014
Merged
@sgrif sgrif mentioned this issue Sep 15, 2014
Closed
rafaelfranca pushed a commit that referenced this issue Oct 15, 2014
@claudiob
Remove duplicate stringify_keys in text_field_tag
a9050e7 
All the methods that invoke `text_field_tag` (such as `hidden_field_tag`)
and all the methods that invoke `number_field_tag` (that is `range_field_tag`)
do not need to call `stringify_keys` on their `options` parameter since the
`text_field_tag` method [is already doing it internally](https://github.com/claudiob/rails/blob/4159134524f4c78d008eef9d9a17f73a3172dcc8/actionview/lib/action_view/helpers/form_tag_helper.rb#L182):

```ruby
def text_field_tag(name, value = nil, options = {})
  tag :input, { "type" => "text", "name" => name, "id" => sanitize_to_id(name), "value" => value }.update(options.stringify_keys)
end
```

and `number_field_tag` is [already doing it internally](https://github.com/claudiob/rails/blob/e3207bdbba55f3806441f22b175557579bc0b051/actionview/lib/action_view/helpers/form_tag_helper.rb#L780) as well:

```ruby
def number_field_tag(name, value = nil, options = {})
  options = options.stringify_keys
  ...
end

[Note #1: My code uses `merge` to respect the existing behavior of
duplicating the `options` hash before updating its keys, see #17096 (comment)]

[Note #2: My code uses symbols instead of strings (e.g.: `:hidden`) to look
forward to future version of Ruby/Raiks (GC symbols); the result of the method,
however, is the same, because the symbols are stringified inside `text_field_tag`]

[Note #3: I had previously created a similar PR #17096 but decided to
split it into multiple PRs given the feedback received in the comments]
seapy added a commit to seapy/rails that referenced this issue Jan 26, 2015
@seapy
Merge pull request rails#1 from seapy/rorlakr_guides_output
9a523a0 
Remove guides/output directory from git
tenderlove pushed a commit that referenced this issue Feb 1, 2015
Merge pull request #1 from mdluo/pr/18316
82e710f 
Fix n+1 query problem when eager loading nil associations (fixes #18312)
@dhh dhh mentioned this issue Feb 15, 2015
Closed
@mMerlin mMerlin mentioned this issue Mar 5, 2015
Closed
keepcosmos pushed a commit to keepcosmos/rails that referenced this issue Jul 12, 2015
@seapy
Merge pull request rails#1 from marocchino/update-welcome
83d46b4 
Fix repo infomation in welcome messages
@KMStanton
Copy link

Rails are on the railroad.

Django was a person.

pcreux referenced this issue Oct 1, 2015
@tenderlove
remove the request parameter from parse_formatted_parameters
8db2e67 
This is an instance method on the request object now so we don't need it
anymore
@bjm88 bjm88 mentioned this issue Dec 8, 2015
Closed
@piotrj piotrj mentioned this issue Jan 30, 2016
Closed
@wisetara wisetara mentioned this issue Feb 20, 2016
Merged
@jeremy jeremy mentioned this issue Mar 19, 2016
Merged
@andsemjiang andsemjiang mentioned this issue May 2, 2016
Closed
@pipermerriam
Copy link

Please re-open. I'm having trouble with require "Django".

irb(main):003:0> require "Django"
LoadError: cannot load such file -- Django
    from /usr/local/Cellar/ruby/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from /usr/local/Cellar/ruby/2.2.3/lib/ruby/2.2.0/rubygems/core_ext/kernel_require.rb:54:in `require'
    from (irb):3
    from /usr/local/bin/irb:11:in `<main>'

@jeremy jeremy mentioned this issue May 11, 2016
Closed
kaspth referenced this issue May 25, 2016
@rafaelfranca
Don't delegate to private methods of the targer
3ac9956 
And make sure that it doesn't even try to call the method in the target.
@rails rails locked and limited conversation to collaborators May 30, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests