Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: coinbase smart wallet support #1964

Merged
merged 36 commits into from
May 18, 2024
Merged

Conversation

magiziz
Copy link
Contributor

@magiziz magiziz commented May 7, 2024

No description provided.

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rainbowkit-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 0:02am
rainbowkit-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2024 0:02am

Comment on lines +84 to +89
export type WindowProvider = {
coinbaseWalletExtension?: WalletProvider | undefined;
ethereum?: WalletProvider | undefined;
phantom?: { ethereum: WalletProvider } | undefined;
providers?: any[] | undefined; // Adjust the type as needed
};
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is a example from wagmi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wagmi/window is deprecated

@DanielSinclair DanielSinclair changed the title feat: coinbaseWallet v4 feat: coinbase smart wallet support May 8, 2024
Copy link

socket-security bot commented May 17, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/viem@2.9.31 network Transitive: environment, filesystem +7 14.7 MB jmoxey

🚮 Removed packages: npm/viem@2.10.9

View full report↗︎

@DanielSinclair DanielSinclair marked this pull request as ready for review May 17, 2024 23:55
@DanielSinclair DanielSinclair requested a review from a team as a code owner May 17, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants