Replace msgraph client. #45485
Open
Replace msgraph client. #45485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigkevmcd
force-pushed
the
replace-hamilton
branch
from
4f27f2c
to
de21bba
Compare
andreas-kupries
approved these changes
May 15, 2024
enrichman
reviewed
May 15, 2024
bigkevmcd
force-pushed
the
replace-hamilton
branch
from
aefbb37
to
33b0225
Compare
enrichman
reviewed
May 15, 2024
bigkevmcd
force-pushed
the
replace-hamilton
branch
from
33b0225
to
d28e1f6
Compare
bigkevmcd
force-pushed
the
replace-hamilton
branch
from
4c13125
to
f09d2af
Compare
bigkevmcd
force-pushed
the
replace-hamilton
branch
3 times, most recently
from
6e2d009
to
852b6f2
Compare
This replaces the manicminer/hamilton dependency with the upstream msgraph client functionality.
Co-authored-by: Enrico Candino <enrico.candino@gmail.com>
Improve the log messages to standardise the prefixes and log out when we receive a value of the wrong type. Reduce the number of contexts being created, ideally we'd receive these as part of the client API definition.
bigkevmcd
force-pushed
the
replace-hamilton
branch
from
852b6f2
to
6b592af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Fixes #45009
Problem
This replaces the manicminer/hamilton dependency with the upstream msgraph client functionality.
Solution
This is a replacement of one package with another.
Testing
This will require detailed login/user import testing.
Engineering Testing
Manual Testing
I've logged in, and things seem to work, user is imported etc.
Automated Testing
Tests are added, but they require upstream API tokens.
Summary: TODO
QA Testing Considerations
Regressions Considerations
TODO
Existing / newly added automated tests that provide evidence there are no regressions: