-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REGEDIT] Implement "Add to favorites" feature #6890
Conversation
return EndDialog(hWnd, err); | ||
} | ||
case IDCANCEL: | ||
return EndDialog(hWnd, ERROR_CANCELLED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really useful to return a Win32 error code there, and in the IDOK case above (caller doesn't use that code at all).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it is not super useful but it costs me nothing so why not?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in regards to the fact the returned result of the DialogBoxW() call below won't really be used.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know the caller does not care at the moment but I have already calculated the error value, it costs me nothing to return it.
The ability to go to a favorite and the dialog was already there, just needed to fill in the blanks.