Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SHELL32] Make brsfolder.c C++ (as brsfolder.cpp) #6906

Merged
merged 5 commits into from
May 19, 2024
Merged

[SHELL32] Make brsfolder.c C++ (as brsfolder.cpp) #6906

merged 5 commits into from
May 19, 2024

Conversation

katahiromz
Copy link
Contributor

@katahiromz katahiromz commented May 18, 2024 •
edited

Purpose

Modernize source code.
JIRA issue: CORE-17340

Proposed changes

  • Move dll/win32/shell32/wine/brsfolder.c to dll/win32/shell32/brsfolder.cpp.
  • Adapt to C++.

TODO

  • Do build.
  • Do check.

@katahiromz katahiromz added refactoring For refactoring changes. shell All PR's related to the shell (and shell extensions) labels May 18, 2024
HBelusca
HBelusca reviewed May 18, 2024
View reviewed changes
dll/win32/shell32/brsfolder.cpp Outdated Show resolved Hide resolved
dll/win32/shell32/brsfolder.cpp Outdated Show resolved Hide resolved
@HBelusca
Copy link
Contributor

I'm fine with the idea.

@katahiromz
Copy link
Contributor Author

Double checked. I have to go further.

@katahiromz katahiromz merged commit 1887773 into reactos:master May 19, 2024
34 checks passed
@katahiromz katahiromz deleted the brsfolder-cxx branch May 19, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HBelusca HBelusca HBelusca left review comments

@learn-more learn-more Awaiting requested review from learn-more learn-more is a code owner

@yagoulas yagoulas Awaiting requested review from yagoulas yagoulas is a code owner

Assignees
No one assigned
Labels
refactoring For refactoring changes. shell All PR's related to the shell (and shell extensions)
Projects
None yet
Milestone
No milestone
2 participants
@katahiromz @HBelusca