This repository has been archived by the owner on Dec 20, 2022. It is now read-only.
apply glob pattern via Path parameter. #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quangson91
reviewed
Oct 12, 2021
There was a problem hiding this comment.
@nayasis Thank you for the PR.
It almost looks great!
I just have some comments related to the code format.
If you have time, you can address these comments.
Otherwise, I will fix that then merge this PR.
Thanks!
|
|
||
| fun String.glob(): List<String> { | ||
|
|
||
| if( ! this.startsWith("glob:") ) return listOf(this) |
There was a problem hiding this comment.
It is better if we format code to make all the code same style.
On the Intellij Idea you can press Ctrl + Alt + L to format code.
|
|
||
| val pattern = this.removePrefix("glob:") | ||
|
|
||
| var root = pattern |
There was a problem hiding this comment.
Perfer to use val than var if possible.
| listOf(this) | ||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
We should add blank line at the end of file to remove this warning from github.
(Some IDE has this setting. On Intellij IDEA, we have a setting: Ensure blank line at the end when save file).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ex.
$ java -jar /path/to/restcli.jar -e "test" glob:*.http