Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicit anchors #667

Merged
merged 4 commits into from
May 12, 2023
Merged

explicit anchors #667

merged 4 commits into from
May 12, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented May 11, 2023

Part of #657

@maelle maelle requested a review from mpadge May 11, 2023 11:39
mpadge
mpadge approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@mpadge mpadge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one! Two questions (purely for my understanding and info):

  1. Are the anchors then the result of you running the explicit anchors script?
  2. What is the significance of the spaces added between the quarto ::: {...} bits and the code chunks?

@maelle
Copy link
Member Author

maelle commented May 11, 2023

Are the anchors then the result of you running the explicit anchors script?

Yes!

What is the significance of the spaces added between the quarto ::: {...} bits and the code chunks?

I think they're fine but will check again. They're a side effect of using tinkr.

@maelle maelle marked this pull request as ready for review May 12, 2023 12:41
@maelle maelle merged commit a51db6b into main May 12, 2023
1 check passed
@maelle maelle deleted the crossrefs branch May 12, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpadge mpadge mpadge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @mpadge