Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops Constructors #72

Open
FintanH opened this issue Apr 9, 2020 · 0 comments
Open

Ops Constructors #72

FintanH opened this issue Apr 9, 2020 · 0 comments

Comments

@FintanH
Copy link
Contributor

FintanH commented Apr 9, 2020

Some functions in the API take a self parameter but they are able to output an Op without the use of self. This can seem quite strange from an API consideration.

If a change was to be made to reorganise this, we could probably do it in two phases:

  1. Define functions that construct the Ops as in impl Op. This constructor can be called from the original function of the CRDT.
  2. Mark the original function as deprecated and eventually remove it.
@FintanH FintanH mentioned this issue Apr 9, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FintanH