Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds support for generic counters #119

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

sunny-g
Copy link

@sunny-g sunny-g commented Jun 11, 2021

No description provided.

@chpio
Copy link
Contributor

chpio commented Jun 11, 2021

What is the purpose/usecase for this? Saving on storage capacity if you only need smaller counters? Other types than ints like enums etc don't make much sens (besides maybe newtypes/int-wrappers).


is MVReg::<_, _, u64> necessary in the code? C defaults to 64, so it shouldn't.

@sunny-g
Copy link
Author

sunny-g commented Jun 12, 2021

@chpio

  1. purpose is so that I can use the BigUint as a counter value in PNCounters.
  2. it shouldn't be required b/c of the default as you stated, but for whatever reason it wouldn't compile. This isn't quite ready for merging yet as I want to fix that issue, and ensure that I'm not imposing stricter trait constraints than necessary on that generic throughout the library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants