-
Notifications
You must be signed in to change notification settings - Fork 12.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rust for Linux auto
CI job
#125209
base: master
Are you sure you want to change the base?
Add Rust for Linux auto
CI job
#125209
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
auto
CI job
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this again! Some more comments/thoughts below...
I guess depending on how things go, i.e. how many failures we get and where they fail most, we could consider reducing or increasing the scope.
I think that the last thing required here is to select some reasonable initial commit. @ojeda any suggestions? I tried the commit that you have sent me before, but it was not found in the repo I think (maybe git just couldn't work with the shorter SHA though). Is there any more up-to-date commit that I could use instead of |
The commit exists, but you probably need something like: mkdir linux
git -C linux init
git -C linux remote add origin https://github.com/torvalds/linux.git
git -C linux fetch --depth 1 origin 8f5b5f78113e881cb8570c961b0dc42b218a1b9e
git -C linux checkout FETCH_HEAD instead of Also, later today Linus will likely tag v6.10-rc1, which we could also use. |
Not sure what you mean, |
Sorry, I meant "what is the most up-to-date commit SHA that works with RfL". |
Both should work (i.e. the one I gave you as well as the current |
If you want to use the RFL repository as the base URL, I can push those commits there too. |
No need for now, if it works with upstream Linux. I changed the commit SHA (thanks for the code to checkout a single commit!), let's see if everything still works. |
My pleasure! |
Ok, looks like it is working, this should be ready for a review now. @rustbot ready Successful CI run: https://github.com/rust-lang/rust/actions/runs/9243326050/job/25427322274?pr=125209 (~12 minutes on a 8 core CI runner). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not an infra expert, but this patch LGMT.
This PR adds an
auto
CI job that checks if Rust for Linux (RfL) still compiles with the latest version of the compiler and the standard library. If not, we should ideally ping the RfL ping group.