Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how String::leak and into_boxed_str differ #125251

Merged
merged 1 commit into from
May 18, 2024
Merged

Clarify how String::leak and into_boxed_str differ #125251

merged 1 commit into from
May 18, 2024
+7 −5

Conversation

jonhoo
Copy link
Contributor

@jonhoo jonhoo commented May 18, 2024

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented May 18, 2024

r? @Nilstrieb

rustbot has assigned @Nilstrieb.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
jonhoo
jonhoo commented May 18, 2024
View reviewed changes
library/alloc/src/string.rs Outdated Show resolved Hide resolved
CryZe
CryZe reviewed May 18, 2024
View reviewed changes
library/alloc/src/string.rs Outdated Show resolved Hide resolved
@Nilstrieb
Copy link
Member

I don't think this change really matches the PR description, it doesn't really make it much clearer what it's useful for. Still, this is a good docs improvement that I'm happy to approve (after you squashed the commits and CI passes).

@jonhoo
Copy link
Contributor Author

jonhoo commented May 18, 2024 •
edited

I don't think this change really matches the PR description, it doesn't really make it much clearer what it's useful for. Still, this is a good docs improvement that I'm happy to approve (after you squashed the commits and CI passes).

Heh, apologies for that, I was encouraged ( 👀 ) to submit this while doing a live stream, and so my attention to detail is somewhat compromised. Have squashed now and updated the title 👍

@jonhoo jonhoo changed the title Make it clearer what String::leak is useful for Clarify how String::leak and into_boxed_str differ May 18, 2024
@jonhoo
Copy link
Contributor Author

jonhoo commented May 18, 2024

@bors rollup

@bors
Copy link
Contributor

bors commented May 18, 2024

@jonhoo: 🔑 Insufficient privileges: not in try users

@jonhoo
Copy link
Contributor Author

jonhoo commented May 18, 2024

Figured I could pro-actively mark this as a fine to roll up, but I guess not 😅

@Nilstrieb
Copy link
Member

i can do that for you :3, thank you for the PR!
@bors r+ rollup
also greetings to your stream viewers if you're still around, i kindly ask you to meow once or twice for them jon :)

@bors
Copy link
Contributor

bors commented May 18, 2024

📌 Commit 0beba96 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2024
@jieyouxu jieyouxu mentioned this pull request May 18, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2024
@bors
Auto merge of rust-lang#125257 - jieyouxu:rollup-11evnm9, r=jieyouxu
b1ec1bd 
Rollup of 3 pull requests

Successful merges:

 - rust-lang#125214 (Only make GAT ambiguous in `match_projection_projections` considering shallow resolvability)
 - rust-lang#125236 (Add tests for `-Zunpretty=expanded` ported from stringify's tests)
 - rust-lang#125251 (Clarify how String::leak and into_boxed_str differ )

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c367d99 into rust-lang:master May 18, 2024
6 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request May 18, 2024
@rust-timer
Unrolled build for rust-lang#125251
48fc8ff 
Rollup merge of rust-lang#125251 - jonhoo:patch-1, r=Nilstrieb

Clarify how String::leak and into_boxed_str differ
@rustbot rustbot added this to the 1.80.0 milestone May 18, 2024
@jonhoo jonhoo deleted the patch-1 branch May 19, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CryZe CryZe CryZe left review comments

@MonterraByte MonterraByte MonterraByte left review comments

@qrnch-jan qrnch-jan qrnch-jan left review comments

Assignees

@Nilstrieb Nilstrieb

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.80.0
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@jonhoo @rustbot @rust-log-analyzer @Nilstrieb @bors @CryZe @MonterraByte @qrnch-jan