New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add causalml support #3273
base: master
Are you sure you want to change the base?
Add causalml support #3273
Conversation
The tests are failing due to an unrelated HuggingFace error: apologies. We'll get that sorted asap (on #3286), and then we can get this PR passing. Edit: done. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3273 +/- ##
==========================================
- Coverage 57.79% 57.75% -0.05%
==========================================
Files 89 89
Lines 12540 12528 -12
==========================================
- Hits 7248 7236 -12
Misses 5292 5292 ☔ View full report in Codecov by Sentry. |
This PR has quite a large diff, as there are many unrelated style changes alongside the functional changes. Please would you remove the style changes, leaving just the functional changes? We plan to introduce python black soon to remove this kind of hassle for contributors. Nb. I inadvertently briefly closed this PR (currently on mobile), apologies. |
Apologies for style change. I will remove it. Python black usage would be great! |
Hi @alexander-pv , do you think you could also add in some tests to Thanks! |
I'll add the "stale" label for now as there hasn't been recent activity. Please feel free to comment if you're still interested in the PR and are happy to work on adding a minimal unit test. |
Hi, @connortann! I added several test to check if shap works as intended with causalml trees. |
About current scikit-learn building issue in recent tests: scikit-learn/scikit-learn#26858 |
Apologies that we haven't had time to look further at this PR, as many maintainers are away over the Christmas period. Thanks again for the PR - I hope to get to this early in the new year. |
Hi, @connortann! I updated the PR resolving a couple of conflicts. Tests work as expected on my computer. Thanks! |
Hi, @connortann. Can you take a look at this PR? This has been a long-standing issue (e.g., uber/causalml#265, uber/causalml#527, uber/causalml#615, uber/causalml#727, uber/causalml#735) for the Your support will be greatly appreciated. |
Overview
Hi!
This PR is reopened #2654
Checklist