New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add waterfall color config for waterfall plot #3377
base: master
Are you sure you want to change the base?
Conversation
…into ENH-cmap-for-waterfall
for more information, see https://pre-commit.ci
…into ENH-cmap-for-waterfall
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #3377 +/- ##
==========================================
+ Coverage 58.18% 58.25% +0.07%
==========================================
Files 89 89
Lines 12564 12588 +24
==========================================
+ Hits 7310 7333 +23
- Misses 5254 5255 +1
☔ View full report in Codecov by Sentry. |
@thatlittleboy @connortann Some time passed since I opened this PR. Do you have time to look at this? |
I've been away recently but back around now, so I'll have some time this week to have a proper look. From a brief read this looks great, but I'd like to give a proper review and think about design choices. This will be a great feature to include. |
Please note that IF we add this, we should probably use this pattern in the other plotting functions aswell. So that we have one dataclass for each plotting function and then we could generalize from there since all configuration options will be visible in the dataclasses. |
I think we should discuss the design choices and make a rough plan; I'd like to run some ideas past you. I'm not sure that a dataclass is the best way to proceed. I'll comment on the issue tracker over at #3266 ... |
Overview
Closes #3266
Description of the changes proposed in this pull request:
Checklist