Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add return figure for summary_plot #3573

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

add return figure for summary_plot #3573

wants to merge 2 commits into from

Conversation

AlKul
Copy link

@AlKul AlKul commented Mar 15, 2024

Overview

Closes #XXXX

Description of the changes proposed in this pull request:

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

@CloseChoice
Copy link
Collaborator

CloseChoice commented Mar 17, 2024

Thanks for the PR. Could you please elaborate a bit what is your intention behind this? So stating your problem with the current implementation would be great for us, so that we have something to put in the release notes later on.
Also at some point we would need to fix the tests.

Another thing that makes me a bit curious is that we plan to deprecate this function. Do you still actively use it?

@AlKul
Copy link
Author

AlKul commented Mar 17, 2024

Thanks for the PR. Could you please elaborate a bit what is your intention behind this? So stating your problem with the current implementation would be great for us, so that we have something to put in the release notes later on. Also at some point we would need to fix the tests.

Another thing that makes me a bit curious is that we plan to deprecate this function. Do you still actively use it?

Hey!
Thanks for quick reply, actually, that was supposed to be pushed to my fork - my bad

And yeah, I’m trying to use this function right now, for analyzing the importance of features for my multi class classification model

I want the plot function return figure - not just plot it (for saving results for each experiment)

And thanks for the lib - just starting using it, looks useful and interesting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants