New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix transformers #3578
base: master
Are you sure you want to change the base?
Fix transformers #3578
Conversation
# Conflicts: # shap/utils/transformers.py
…transformers list instead
The failed test looks like a connection problem to me. Can you rerun the pipeline? |
cc @connortann |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I have not checked this thoroughly yet but this looks amazing. Will come back later this week with a more in-depth review.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3578 +/- ##
==========================================
- Coverage 61.46% 61.45% -0.01%
==========================================
Files 90 90
Lines 12746 12748 +2
==========================================
Hits 7834 7834
- Misses 4912 4914 +2 ☔ View full report in Codecov by Sentry. |
Overview
Closes #3217
There were two problems when using a current transformer model. The first was fixed in #3536 and resulted in all SHAP values being zero. The second problem is that the list of transformer models is hard-coded, so each new model would require a new entry. Fortunately, the transformers library provides such a list, so I changed the code to check against their lists.
Minimal working example (random model, random question)
Checklist