Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update notebooks #3591

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CloseChoice
Copy link
Collaborator

Overview

Closes #3581

Description of the changes proposed in this pull request:

  • fix error in notebook
  • remove notebook from allow_to_timeout and improve timeout to 30

Checklist

  • All pre-commit checks pass.
  • Unit tests added (if fixing a bug or adding a new feature)

Copy link
Collaborator

@connortann connortann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one comment, please would you re-run the cells top-to-bottom so the execution counts are tidy?

@connortann connortann added the documentation Relating to readthedocs, notebooks, and exposition in docstrings label Mar 28, 2024
@CloseChoice
Copy link
Collaborator Author

done. This actually took me so long because I was really perplexed when I saw the tensorflow warning in this Pytorch notebook and investigated this a bit. It comes down to someplace where we import both in the same file, but I did not figure out a good way to demangle this. We should probably open an issue about this, e.g. the notebook throws an error if tf_keras is not installed.

@CloseChoice
Copy link
Collaborator Author

I just leave the warning here as we might clean this up in a separate PR and get this example working again.

@CloseChoice
Copy link
Collaborator Author

just created a new issue for this #3662

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Relating to readthedocs, notebooks, and exposition in docstrings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: 0.45.0 update breaks pytorch example on docs
2 participants