[MOB-70] Update Folder/Files when renamed on iOS #2225
Draft
+276
−109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For folders being renamed, iOS throws a Create Event with the new path, and then a Modify event with the old path. So, I needed to add a new function just for folder renames.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I had to change how `starts_with` works, but now renames work fine on iOS for both files and folders, no matter how deep they are in a location.
Rocky43007
changed the title
fogodev
requested changes
Mar 21, 2024
|
Working on a fix to multiple rename events being set at the same time because otherwise, it's broken and crashes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a folder or file has been renamed externally on iOS, the core has no idea how to handle this event, throwing errors and disappearing the folder/file.
Looks like it's due to iOS sending a Create Event with the new Folder instead of sending it as a Rename Event.