Depend on tensorflow-macos on M1, to support separate install #1860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensorflow doesn't run directly on an Apple M1 machine, either natively (arm64) or under Rosetta (x86-64). Apple has provided preview builds at https://github.com/apple/tensorflow_macos which can be manually installed, to provide the
tensorflow-macos
package, which is still imported asimport tensorflow
. If these are manually installed then, theoretically, StellarGraph should be able to run. This patch makes this more feasible, by changing the phrasing of the Tensorflow dependency totensorflow-macos
when running on (what looks like) an M1 mac. This allows installation to proceed somewhat further, as it's no longer looking for a compatibletensorflow
package on PyPI.This is a draft PR, because I haven't yet got this to work fully:
OPENBLAS="$(brew --prefix openblas)" pip install -e .
fails ingrpcio
(looks like grpc/grpc#24677):Fixes #1856