-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default settings update #7
Default settings update #7
Conversation
- Expanding selectors to support the whole range of languages that server supports. - Default path set to `/usr/bin/sourcekit-lsp`
Draft until the decision about the |
60e82d0
to
9fa986c
Compare
9fa986c
to
bb6000d
Compare
bb6000d
to
aac861d
Compare
Co-authored-by: Rafał Chłodnicki <rchl2k@gmail.com>
Done |
LSP-SourceKit.sublime-settings
Outdated
"languageId": "swift" | ||
} | ||
] | ||
// Enable this server globally for all the scopes provided in "selector" property. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is not up to date since it we don't enable globally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I'm trying to say here, is the purpose of this setting, that toggles the server globally, so I believe that this is rather correct comment that describes what user will get if he/she overrides this setting.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is for the enabled: false
setting which doesn't make sense.
Also, even if it would correctly state the actual state, it would be stating the obvious so it's not needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I disagree with that, an opaque setting "enabled": false
in a random github repo is far for being self descriptive for a folk who is not familiar with both ST and LSP internals.
Folk that came here especially from an Apple repo most likely would have zero knowledge about this toggle purpose so we should guide him/her here without forcing he/she to dig the purpose of the config values deeper.
UPD: still rephrased this sentence a bit for a clarifying sake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, the main issue with that comment is that it's not stating the correct thing. If you want to keep it then make it something like:
Disabled globally. Run "LSP: Enable Language Server in Project" from the Command Palette to enable per-project.
The part about selector is stating the obvious so shouldn't need a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the update of this issue was missed coz of force push and UPD of a previous comment.
I've updated the hint a bit, please consider it when you'll have time.
8f6261d
to
9019280
Compare
9019280
to
e0d7559
Compare
Spawned by discussions here and here.
xcrun
referencing in the code./usr/bin/sourcekit-lsp