Skip to content

Commit

Permalink
Modulated 3D Wavetable Curve didn't Z-Shift (#842)
Browse files Browse the repository at this point in the history
* Modulated 3D Wavetable Curve didn't Z-Shift

Fixes this problem by using the modulated value for the z position
in the recalc path 3d calculation. Basically a bug when porting from
juce.

Closes #841

* f
  • Loading branch information
baconpaul committed Feb 14, 2023
1 parent 9fa5335 commit c8f73c3
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 4 deletions.
6 changes: 5 additions & 1 deletion docs/changelog.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Surge XT VCV Modules Changelog

## 2.1.2 - February 2023
## 2.1.3

- Fix for wavetable 3d position display when modulating Morph parameter

## 2.1.2 - February 2023 (Skipped in library)

- Add a 'slow' mode to the EGxVCA which allows ADSR times up to 120 seconds
- Fix an EGxVCA problem where monophonic gates with polyphonic signals would
Expand Down
14 changes: 11 additions & 3 deletions src/VCO.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -675,9 +675,17 @@ struct OSCPlotWidget : public rack::widget::TransparentWidget, style::StyleParti
{
case ot_wavetable:
case ot_window:
pos = oscdata->p[0].val.f;
off = oscdata->p[0].extend_range;
break;
{
auto par = &(oscdata->p[0]);
pos = par->val.f;
if (module->animateDisplayFromMod)
{
pos +=
module->modAssist.modvalues[0 + 1][0] * (par->val_max.f - par->val_min.f);
}
off = par->extend_range;
}
break;
default:
pos = 0.f;
break;
Expand Down

0 comments on commit c8f73c3

Please sign in to comment.