Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that VCV Rack has an official dark theme switch we can get a bit closer to the official Rack approach.
The Cardinal custom
rack::settings::darkMode
is being deprecated in favour of the officialrack::settings::preferDarkPanels
I still do not like having the "mid" as the initial surge theme though, so light/dark switch remains for the initial/first instance of your plugins.
Thanks for the nice modules once again
Next Cardinal release is planned for 15th of January btw.