Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less cardinal specific changes #974

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

falkTX
Copy link
Contributor

@falkTX falkTX commented Jan 5, 2024

Now that VCV Rack has an official dark theme switch we can get a bit closer to the official Rack approach.
The Cardinal custom rack::settings::darkMode is being deprecated in favour of the official rack::settings::preferDarkPanels

I still do not like having the "mid" as the initial surge theme though, so light/dark switch remains for the initial/first instance of your plugins.

Thanks for the nice modules once again

Next Cardinal release is planned for 15th of January btw.

@falkTX
Copy link
Contributor Author

falkTX commented Jan 5, 2024

now that I see #921 it is then better to not merge this, because the integration with the new rack API is not completed.

I will force-push soon so that rack::settings::darkMode is updated, but stick with everything else as-is.

PS: if you want to have compat for new Rack APIs while being usable on old Rack versions I think a dlopen(null) + dlsym would do the trick, basically finding the location of the "bool preferDarkPanels" variable that lives within libRack.

Signed-off-by: falkTX <falktx@falktx.com>
@falkTX
Copy link
Contributor Author

falkTX commented Jan 5, 2024

ok I redid the PR and the changes are very minimal now, it is okay for merging from my side.

@baconpaul
Copy link
Contributor

Thanks!

@baconpaul baconpaul merged commit e96ba1e into surge-synthesizer:main Jan 5, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants