Skip to content

Commit

Permalink
Update developer.md
Browse files Browse the repository at this point in the history
Clean up namespace discussion now we have no more using namespace std in globals.h
  • Loading branch information
baconpaul committed Feb 7, 2019
1 parent 552db93 commit c2ec249
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion doc/developer.md
Expand Up @@ -49,8 +49,9 @@ section stick to 3 spaces. If you are writing new code we are OK with 3 or 4. Bu
* `class HaveCamelcaseNames`
* `void functionsAreCamelCaseWithLowerFirst`
* We are not using `s_` or `m_` or equivalent notations for members or statics
* Full namespaces are generally prefered over usings. Even though the code has a `using std` in globals.h we are trying to use
* Full namespaces are generally prefered over usings. We are trying to use
`std::vector` over `vector` in the code.
* Don't `using namespace` in header files. Don't `using namespace std` in new code (but it is in some existing code).
* Use namespaces not classes to group functions. Check out how we implemented `UserInteractions.h`
* Long and descriptive names are good. `userMessageDeliveryPipe` is better than `umdp`.

Expand Down

0 comments on commit c2ec249

Please sign in to comment.