Clamp Max Porta time to 16 seconds #7317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Max porta time was 2 (aka "4 seconds") but was modulatable across the entire range up to about 128 seconds I think. That's the same as stuck. So add an internal clamp which means even in extreme off the end modulation, you cap out at 16 seconds. Addresses case 2 of surge-synthesizer#7301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Max porta time was 2 (aka "4 seconds") but was modulatable across the entire range up to about 128 seconds I think. That's the same as stuck. So add an internal clamp which means even in extreme off the end modulation, you cap out at 16 seconds.
Addresses case 2 of #7301