Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html: Add one-click access to #folder-sharing & #device-sharing (fixes #8972) #9484

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bugith
Copy link

@bugith bugith commented Mar 27, 2024

Purpose

Add links to quick access from a Folder to its members edit screen (#folder-sharing) and from a RemoteDevice to the list of folders they are enrolled edit screen (#device-sharing).

Testing

Open a folder in the GUI. A link beside "Shared With" item will bring you to direct membership edition.
Open a device in the GUI. A link beside "Folders" item would bring you to direct edition of clusters list for this device... although this last won't do the job fully because it only displays the #device-general dialog.. I don't understand why... please advise a newb

Screenshots

image
image

Authorship

Your name and email will be added automatically to the AUTHORS file
based on the commit metadata.

…fixes syncthing#8972)

Add links to quick access from a Folder to its members edit screen (#folder-sharing) and from a RemoteDevice to the list of folders they are enrolled edit screen (#device-sharing).
@bugith
Copy link
Author

bugith commented Mar 27, 2024

I didn't add a <i class="small" translate>Edit</i> beside the pencil to remain as discrete as possible since we also have now an hypertext list of devices and maybe soon folders too if @Jaspitta adds this.

@acolomb
Copy link
Member

acolomb commented Mar 27, 2024

As explained on the forum, I doubt the usefulness of this shortcut. It's just one click instead of two, and even on parity if the last used tab was the Sharing in that dialog. Click Edit > click Sharing.

See https://forum.syncthing.net/t/shared-with-settings-implementation/21855

@bugith
Copy link
Author

bugith commented Mar 28, 2024

Ok André & Tomas
But please, so that my yesterday work day keeps some interest at least for me, could you point me why the link in the Devices pane does not work as expected (ng-click="editDeviceExisting(deviceCfg, '#device-sharing')")?
Thank you

@tomasz1986
Copy link
Contributor

tomasz1986 commented Mar 28, 2024

Ok André & Tomas But please, so that my yesterday work day keeps some interest at least for me, could you point me why the link in the Devices pane does not work as expected (ng-click="editDeviceExisting(deviceCfg, '#device-sharing')")? Thank you

I think going to a specific tab directly simply hasn't been implemented for devices. It has been used for folders for a long time because of the ignore patterns link, but so far there has been no need for something similar when it comes to devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants