Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render Other CJK Languages' Fonts With Proper Language Attribute #974

Closed
MarvNC opened this issue May 19, 2024 · 0 comments · Fixed by #979
Closed

Render Other CJK Languages' Fonts With Proper Language Attribute #974

MarvNC opened this issue May 19, 2024 · 0 comments · Fixed by #979
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@MarvNC
Copy link
Member

MarvNC commented May 19, 2024

https://github.com/MarvNC/yomichan-dictionaries?tab=readme-ov-file#yomitan-css-for-non-japanese-cjk-languages

I have an override here but for some languages it would be nice if this was built into Yomitan itself in the proper way.
@MarvNC MarvNC added the kind/enhancement The issue or PR is a new feature or request label May 19, 2024
@MarvNC MarvNC changed the title Render Other Languages With Proper Language Attribute Render Other CJK Languages Font With Proper Language Attribute May 19, 2024
@MarvNC MarvNC mentioned this issue May 19, 2024
Open
@MarvNC MarvNC changed the title Render Other CJK Languages Font With Proper Language Attribute Render Other CJK Languages' Fonts With Proper Language Attribute May 19, 2024
@Kuuuube Kuuuube mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix HTML lang tags not matching the selected language Kuuuube/yomitan
1 participant
@MarvNC