Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add isTextLookupWorthy function for Chinese #743

Merged
merged 8 commits into from
Jun 1, 2024
Merged

Add isTextLookupWorthy function for Chinese #743

merged 8 commits into from
Jun 1, 2024

Conversation

cashewnuttynuts
Copy link
Collaborator

No description provided.

@cashewnuttynuts cashewnuttynuts requested a review from a team as a code owner February 29, 2024 13:24
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Feb 29, 2024 •
edited

CodSpeed Performance Report

Merging #743 will not alter performance

Comparing Scrub1492:is-chinese-check-move (f715a76) with master (2c5af21)

Summary

✅ 3 untouched benchmarks

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 29, 2024 •
edited

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@cashewnuttynuts cashewnuttynuts added kind/enhancement The issue or PR is a new feature or request area/linguistics The issue or PR is related to linguistics labels Feb 29, 2024
@cashewnuttynuts
Copy link
Collaborator Author

(Not sure how to make the eslint errors go away)

StefanVukovic99
StefanVukovic99 reviewed Feb 29, 2024
View reviewed changes
ext/js/language/language-util.js Outdated Show resolved Hide resolved
ext/js/language/language-util.js Outdated Show resolved Hide resolved
themoeway-bot
themoeway-bot previously approved these changes Mar 3, 2024
View reviewed changes
@djahandarie
Copy link
Collaborator

@toasted-nutbread Do you know what's up with the unit test errors regarding the sandbox?

@toasted-nutbread
Copy link
Collaborator

There are some modifications required to the eslint file. Look at https://github.com/themoeway/yomitan/actions/runs/8127814945/job/22213051541, find the corresponding override with the list of files and that environment, and the unit test indicates which array elements should be added or removed.

@StefanVukovic99
Copy link
Member

conflict 🙏

@jamesmaa jamesmaa mentioned this pull request May 31, 2024
Closed
@StefanVukovic99
Copy link
Member

This should be fixed up now

@StefanVukovic99 StefanVukovic99 linked an issue May 31, 2024 that may be closed by this pull request
Carry #743 over the finish line #1018
Closed
@jamesmaa jamesmaa added this pull request to the merge queue May 31, 2024
Merged via the queue into themoeway:master with commit b6341f3 Jun 1, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toasted-nutbread toasted-nutbread toasted-nutbread left review comments

@StefanVukovic99 StefanVukovic99 StefanVukovic99 left review comments

@jamesmaa jamesmaa jamesmaa approved these changes

@themoeway-bot themoeway-bot themoeway-bot left review comments

Assignees
No one assigned
Labels
area/linguistics The issue or PR is related to linguistics kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Carry #743 over the finish line
6 participants
@cashewnuttynuts @djahandarie @toasted-nutbread @StefanVukovic99 @jamesmaa @themoeway-bot