-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for overwriting existing card #859
add support for overwriting existing card #859
Conversation
✔️ No visual differences introduced by this PR. View Playwright Report (note: open the "playwright-report" artifact) |
I think this is good to go |
Are you able to test/check if this works on ankiconnect android? Not a blocker but just so we know what to expect. |
Not easily, I've never tested anything on mobile |
Looks like when there are multiple duplicate cards it just picks the first one to overwrite. Might be good to make it clear to users in some way which card is being overwritten. |
Looked over everything and tested all cases of the The only problem I found is when the model of the duplicate note and the selected anki note model don't match and the duplicate note is in the same deck, attempting to overwrite does nothing. The button should probably be grayed out for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving despite the previously mentioned issue.
It isn't reasonable to pull the existing duplicate notes from anki to check their model and could lead to big slowdowns in the anki buttons appearing if it pulls notes that have a lot of media.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really not a fan of the recycle icon because it's so overloaded with semantics. It could mean recycle, reset. I feel like the semantic "overwrite" wouldn't show up in people's vocabulary until like 5 definitions down.
I'm going to mark this as non-blocking since we can change it in the future.
Implements part of #578