[ja] add preprocessor for width of alphabetic characters #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanVukovic99
added
kind/enhancement
Kuuuube
reviewed
May 18, 2024
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>
Kuuuube
reviewed
May 18, 2024
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: StefanVukovic99 <stefanvukovic44@gmail.com>
StefanVukovic99
force-pushed
the
alphabetic-width-variants
branch
from
354575f
to
1211bd7
Compare
|
Performance on this is OK now since we merged #973, ready for review 🙏 |
jamesmaa
approved these changes
May 22, 2024
| @@ -523,16 +524,39 @@ export function convertHiraganaToKatakana(text) { | |||
| * @param {string} text | |||
| * @returns {string} | |||
| */ | |||
| export function convertNumericToFullWidth(text) { | |||
| export function convertAlphanumericToFullWidth(text) { | |||
| let result = ''; | |||
There was a problem hiding this comment.
Would this be more performant using an array than string concatenation? Not sure if this is the performance bottleneck
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961