Browser agnostic search page clipboard and selection handling #965
Conversation
Kuuuube
added
kind/bug
| @@ -66,11 +66,11 @@ export class SearchDisplayController { | |||
| /** @type {boolean} */ | |||
| this._clipboardMonitorEnabled = false; | |||
| /** @type {import('clipboard-monitor').ClipboardReaderLike} */ | |||
| const clipboardReader = { | |||
| this.clipboardReaderLike = { | |||
There was a problem hiding this comment.
What does Like mean here?
There was a problem hiding this comment.
Makes it clear that this isnt an instance of the clipboardReader class and doesn't have all the function of it but has similar base function. Similar to an "arraylike" type where theres an array that might be able to do the array storage stuff but it might not be able to do push() or pop() for example.
There was a problem hiding this comment.
In other languages you would accomplish this by typing an interface but ig js doesn't have this pattern
| @@ -268,10 +268,9 @@ export class SearchDisplayController { | |||
| } | |||
|
|
|||
| /** */ | |||
| _onCopy() { | |||
| async _onCopy() { | |||
There was a problem hiding this comment.
Why did you change this to async? I would've thought a function signature change would require changing the call sites of _onCopy as well
There was a problem hiding this comment.
_onCopy runs based off of an event listener. Event listener calls are essentially voids.
Due to a 23 year old Firefox bug (https://bugzilla.mozilla.org/show_bug.cgi?id=85686) window.getSelection() does not behave the same on Firefox as it does on Chromium.
It is not possible to get the current selection using this if a textarea or input is where the selection is located on Firefox. It is possible to achieve this using other methods but none of these methods work for fetching the selection anywhere on the page. So there is no equivalent of window.getSelection() to be used.
To avoid jank I've rewritten the code to check whether the user has the browser page focused instead using document.hasFocus(). If the user has the browser page focused, updating the search from a clipboard copy is blocked.
I searched the blame for this code back to when it was added to check if there were any edge cases this was handling but there doesn't appear to be any specifc reason window.getSelection() was chosen so it should be fine to switch out.
The Yomitan bug this fixes is the search page updating when copying out of the textarea search box on the search page on Firefox.
Tested on Firefox and Chromium.