Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edited README #978

Merged
merged 39 commits into from
May 21, 2024
Merged

Edited README #978

merged 39 commits into from
May 21, 2024

Conversation

martholomew
Copy link

I stole a lot of the "contributing" text from @jamesmaa

Moved things around, added (perhaps) an obscene amount of emojis, etc.

Let me know how it looks!

Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
@martholomew martholomew requested a review from a team as a code owner May 20, 2024 01:24
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
sad day

Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
README.md Show resolved Hide resolved
moved cat to better spot

Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
martholomew and others added 2 commits May 20, 2024 23:25
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@Kuuuube
Copy link
Member

Kuuuube commented May 21, 2024

Also a few other things I found while reviewing this that should be fixed even though you don't touch them.

※ Unlike Chrome, Firefox does not allow extensions meant for testing to be hosted in the marketplace.
- You will have to download a desired version and side-load it yourself. You only need to do this once and will get
updates automatically.
※ Unlike Chrome, Firefox does not allow extensions meant for testing to be hosted in the marketplace.
+ You will have to download the desired version and side-load it yourself. You only need to do this once, and you will get
updates automatically.
- 2.  Import the dictionaries you wish to use for term and kanji searches, head over to the [the dictionary docs](./docs/dictionaries.md) to get set up! If you do not have any dictionaries installed or enabled, Yomitan will warn you that it is not ready for use by displaying an orange exclamation mark over its icon. This exclamation mark will disappear once you have installed and enabled at least one dictionary.
+ 2.  Import the dictionaries you wish to use for term and kanji searches; head over to the [dictionary docs](./docs/dictionaries.md) to get set up! If you do not have any dictionaries installed or enabled, Yomitan will warn you that it is not ready for use by displaying an orange exclamation mark over its icon. This exclamation mark will disappear once you have installed and enabled at least one dictionary.
- 5.  Click on individual kanji in the term definition results to view additional information about those characters, including stroke order diagrams, readings, meanings, as well as other useful data.
+ 5.  Click on individual kanji in the term definition results to view additional information about those characters, including stroke order diagrams, readings, meanings, and other useful data.

@Kuuuube Kuuuube added the area/documentation The issue or PR is about documentation label May 21, 2024
martholomew and others added 17 commits May 21, 2024 11:39
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Kuuuube
Kuuuube previously approved these changes May 21, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
jamesmaa
jamesmaa previously approved these changes May 21, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: James Maa <jmaa@berkeley.edu>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
@jamesmaa jamesmaa enabled auto-merge May 21, 2024 18:38
@jamesmaa jamesmaa added this pull request to the merge queue May 21, 2024
Merged via the queue into themoeway:master with commit e91d9ad May 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation The issue or PR is about documentation kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants