forked from FooSoft/yomichan
-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edited README #978
Merged
Merged
Edited README #978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
sad day Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
MarvNC
reviewed
May 20, 2024
moved cat to better spot Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
MarvNC
reviewed
May 20, 2024
MarvNC
reviewed
May 20, 2024
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
MarvNC
approved these changes
May 21, 2024
Kuuuube
requested changes
May 21, 2024
Kuuuube
requested changes
May 21, 2024
Kuuuube
requested changes
May 21, 2024
Also a few other things I found while reviewing this that should be fixed even though you don't touch them. ※ Unlike Chrome, Firefox does not allow extensions meant for testing to be hosted in the marketplace.
- You will have to download a desired version and side-load it yourself. You only need to do this once and will get
updates automatically.
※ Unlike Chrome, Firefox does not allow extensions meant for testing to be hosted in the marketplace.
+ You will have to download the desired version and side-load it yourself. You only need to do this once, and you will get
updates automatically. - 2. Import the dictionaries you wish to use for term and kanji searches, head over to the [the dictionary docs](./docs/dictionaries.md) to get set up! If you do not have any dictionaries installed or enabled, Yomitan will warn you that it is not ready for use by displaying an orange exclamation mark over its icon. This exclamation mark will disappear once you have installed and enabled at least one dictionary.
+ 2. Import the dictionaries you wish to use for term and kanji searches; head over to the [dictionary docs](./docs/dictionaries.md) to get set up! If you do not have any dictionaries installed or enabled, Yomitan will warn you that it is not ready for use by displaying an orange exclamation mark over its icon. This exclamation mark will disappear once you have installed and enabled at least one dictionary. - 5. Click on individual kanji in the term definition results to view additional information about those characters, including stroke order diagrams, readings, meanings, as well as other useful data.
+ 5. Click on individual kanji in the term definition results to view additional information about those characters, including stroke order diagrams, readings, meanings, and other useful data. |
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Co-authored-by: Kuuuube <61125188+Kuuuube@users.noreply.github.com> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
Kuuuube
previously approved these changes
May 21, 2024
Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
jamesmaa
previously approved these changes
May 21, 2024
Co-authored-by: James Maa <jmaa@berkeley.edu> Signed-off-by: Matttttt <18152455+martholomew@users.noreply.github.com>
jamesmaa
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/documentation
The issue or PR is about documentation
kind/enhancement
The issue or PR is a new feature or request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stole a lot of the "contributing" text from @jamesmaa
Moved things around, added (perhaps) an obscene amount of emojis, etc.
Let me know how it looks!