fix .com and .org domain in documentation #10635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fix looks correct to me. |
nmengin
added
area/documentation
status/2-needs-review
and removed
status/0-needs-triage
labels
|
FYI I closed/re-opened the PR to launch the CI. |
mmatur
approved these changes
May 27, 2024
|
🚫 checks status: PR status: failure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
fix documentation error
Motivation
Based on https://github.com/traefik/traefik/blob/v2.11/docs/content/https/acme.md, which says
It looks like the main domain should be example.com and the SAN should be example.org, but the included YAML files did not show that.
More
Additional Notes
Please check if this is correct.