-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix OTel documentation #10723
Merged
Merged
Fix OTel documentation #10723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nmengin
added
area/documentation
kind/bug/fix
a bug fix
area/middleware/metrics
status/2-needs-review
and removed
status/0-needs-triage
labels
May 15, 2024
rtribotte
requested changes
May 15, 2024
kevinpollet
requested changes
May 15, 2024
kevinpollet
approved these changes
May 15, 2024
kevinpollet
added
bot/light-review
decreases the number of required LGTM from 3 to 1.
status/3-needs-merge
and removed
status/2-needs-review
labels
May 15, 2024
🚫 error related to review: CHANGES_REQUESTED by rtribotte |
rtribotte
approved these changes
May 16, 2024
Co-authored-by: Romain <rtribotte@users.noreply.github.com> Co-authored-by: Kevin Pollet <pollet.kevin@gmail.com>
traefiker
removed
status/3-needs-merge
bot/light-review
decreases the number of required LGTM from 3 to 1.
labels
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the observability documentation to mention OpenTelemetry where is makes sense.
Motivation
Provide a relevant documentation about OTel in traefik v3.
More
- [ ] Added/updated tests