Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1 Unit Tests for Groups #458

Closed
wants to merge 39 commits into from
Closed

V1 Unit Tests for Groups #458

wants to merge 39 commits into from

Conversation

andrewhand
Copy link
Collaborator

No description provided.

@andrewhand
build(restapi): Added unit tests for groups.
5bc86a8
@andrewhand
build(restapi): Removed tags and resources from expected contents
76f6b76
@andrewhand
build(restapi): Added unit tests for groups.
4346383
@andrewhand
build(restapi): Removed tags and resources from expected contents
55faf52
@andrewhand
Merge branch 'v1-groups-unit-tests' of https://github.com/usnistgov/d…
b5d7033 
…ioptra into v1-groups-unit-tests
@andrewhand
build(restapi): added functions to actions and conftest for testing g…
6e77451 
…roups
@andrewhand
tests(restapi): Fixed query key for test_group_search_query.
812cdf9
@andrewhand
build(restapi): Added unit tests for groups.
60056d0
@andrewhand
build(restapi): Removed tags and resources from expected contents
34654b5
@andrewhand
build(restapi): Added unit tests for groups.
4b2f112
@andrewhand
build(restapi): Removed tags and resources from expected contents
c127f0c
@andrewhand
build(restapi): added functions to actions and conftest for testing g…
a463931 
…roups
@andrewhand
tests(restapi): Fixed query key for test_group_search_query.
9991788
@andrewhand
Merge branch 'v1-groups-unit-tests' of https://github.com/usnistgov/d…
c4f11c3 
…ioptra into v1-groups-unit-tests
@andrewhand andrewhand changed the title [WIP] Added unit tests for groups. Unit Tests for Groups May 14, 2024
@andrewhand andrewhand changed the title Unit Tests for Groups V1 Unit Tests for Groups May 14, 2024
keithmanville
keithmanville requested changes May 14, 2024
View reviewed changes
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Show resolved Hide resolved
jkglasbrenner
jkglasbrenner requested changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@jkglasbrenner jkglasbrenner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the inline comments, we also mentioned during this morning's session that we've added a description field for all of the resources in Dioptra, so that's something that can be incorporated in this pull request.

tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Show resolved Hide resolved
tests/unit/restapi/v1/test_groups.py Outdated Show resolved Hide resolved
tests/unit/restapi/lib/actions.py Outdated Show resolved Hide resolved
andrewhand and others added 12 commits May 17, 2024 11:17
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
6601fa7 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
8036229 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
cac3013 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
77c6210 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
0a7bf75 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/v1/test_groups.py
dedab79 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand @jkglasbrenner
Update tests/unit/restapi/lib/actions.py
b7aca18 
Co-authored-by: James K. Glasbrenner <jglasbrenner@mitre.org>
@andrewhand
test(restapi): Fixed case issue with validation of contents
27264c1
@andrewhand
test(restapi): Added owner and admin validation checks
016ba98
@andrewhand
test(restapi): Removed redundant test case
dd4e120
@andrewhand
chore(restapi): Fixed minor issue with docstring
79cdc8b
@andrewhand
test(restapi): Added description field to groups unit testing
2b90d9e
@andrewhand
Copy link
Collaborator Author

andrewhand commented May 17, 2024 •
edited

In addition to the inline comments, we also mentioned during this morning's session that we've added a description field for all of the resources in Dioptra, so that's something that can be incorporated in this pull request.

Added descriptions to groups testing in commit: 2b90d9e

Will need a review before merge @jkglasbrenner @keithmanville

@keithmanville
Copy link
Collaborator

integrated into #468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkglasbrenner jkglasbrenner jkglasbrenner requested changes

@keithmanville keithmanville keithmanville requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewhand @keithmanville @jkglasbrenner