Add LabelVariable #832
Open
Add LabelVariable #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Useful for, e.g., https://pages.nist.gov/pfhub/benchmarks/benchmark8.ipynb
|
A few test cases? It took me a while to figure out what it was supposed to do. It only works in 2D right? Maybe have an exception in the init with different dimension? |
wd15
reviewed
Nov 26, 2021
Imports were messed up and never tested
I'm supposed to have tests just because the code I uploaded didn't work at all? |
tkphd
reviewed
May 20, 2023
There was a problem hiding this comment.
I wonder what the limits on "distinct non-zero regions" are in scipy.ndimage.label. Assuming (without direct evidence) that the
| [[0,1,0], | ||
| [1,1,1], | ||
| [0,1,0]] | ||
| dtype : date-type, optional |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for, e.g., https://pages.nist.gov/pfhub/benchmarks/benchmark8.ipynb