Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Cleanup #32

Open
wants to merge 38 commits into
base: main
Choose a base branch
from
Open

Code Cleanup #32

wants to merge 38 commits into from

Commits on Apr 9, 2024

  1. delete unwanted files

    @purav-parekh
    purav-parekh committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    3fead94 View commit details
    Browse the repository at this point in the history

  2. remove code redundancy

    @purav-parekh
    purav-parekh committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    5838975 View commit details
    Browse the repository at this point in the history

  3. fix few type errors

    @purav-parekh
    purav-parekh committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    b21a644 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    ba2a278 View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    bf5bada View commit details
    Browse the repository at this point in the history

  2. remove payback charts

    @purav-parekh
    purav-parekh committed Apr 16, 2024
    Configuration menu
    Copy the full SHA
    85a9250 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    60eda36 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2024

  1. cleanup & type fixes pt1

    @purav-parekh
    purav-parekh committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    02ca82c View commit details
    Browse the repository at this point in the history

  2. small fix to remove hardcoded value

    @purav-parekh
    purav-parekh committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    69960ac View commit details
    Browse the repository at this point in the history

  3. move Results to independent file

    @purav-parekh
    purav-parekh committed Apr 18, 2024
    Configuration menu
    Copy the full SHA
    adef05d View commit details
    Browse the repository at this point in the history

Commits on Apr 23, 2024

  1. project desc conditionally shown

    @purav-parekh
    purav-parekh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    b76ef6a View commit details
    Browse the repository at this point in the history

  2. fix some type errors

    @purav-parekh
    purav-parekh committed Apr 23, 2024
    Configuration menu
    Copy the full SHA
    cb47b02 View commit details
    Browse the repository at this point in the history

Commits on Apr 24, 2024

  1. fix more type errors

    @purav-parekh
    purav-parekh committed Apr 24, 2024
    Configuration menu
    Copy the full SHA
    4fb38b5 View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2024

  1. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d08d905 View commit details
    Browse the repository at this point in the history

  2. fix some type errors

    @purav-parekh
    purav-parekh committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    85de8a0 View commit details
    Browse the repository at this point in the history

  3. fix formats

    @purav-parekh
    purav-parekh committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    b7d90fc View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2024

  1. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    96be6d8 View commit details
    Browse the repository at this point in the history

  2. refactor CSV code

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    779d3e6 View commit details
    Browse the repository at this point in the history

  3. fix minor tab number issue

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    88f6924 View commit details
    Browse the repository at this point in the history

  4. refactor code for the input table

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    c66b89e View commit details
    Browse the repository at this point in the history

  5. refactor charts code

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    e674fef View commit details
    Browse the repository at this point in the history

  6. refactor step three code

    @purav-parekh
    purav-parekh committed Apr 30, 2024
    Configuration menu
    Copy the full SHA
    20c21ee View commit details
    Browse the repository at this point in the history

Commits on May 1, 2024

  1. fix some more type errors

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    805e787 View commit details
    Browse the repository at this point in the history

  2. type fixes & minor cleanup

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    becd41b View commit details
    Browse the repository at this point in the history

  3. fix type errors

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    097129b View commit details
    Browse the repository at this point in the history

  4. delete unused package

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    1a901df View commit details
    Browse the repository at this point in the history

  5. fix type errors in e3Request

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    c7b2f38 View commit details
    Browse the repository at this point in the history

  6. allow discount values to be 0

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    9ffae45 View commit details
    Browse the repository at this point in the history

  7. fix type errors pt n

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    549e0af View commit details
    Browse the repository at this point in the history

  8. scrolls to step2 only during validation

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    ea7612c View commit details
    Browse the repository at this point in the history

  9. fixing more type errors

    @purav-parekh
    purav-parekh committed May 1, 2024
    Configuration menu
    Copy the full SHA
    0e09e83 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Merge branch 'main' into code-cleanup

    @purav-parekh
    purav-parekh committed May 8, 2024
    Configuration menu
    Copy the full SHA
    b7781e9 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. improve pdf styling

    @purav-parekh
    purav-parekh committed May 13, 2024
    Configuration menu
    Copy the full SHA
    a62cdaa View commit details
    Browse the repository at this point in the history

  2. irr displays 2 decimals always

    @purav-parekh
    purav-parekh committed May 13, 2024
    Configuration menu
    Copy the full SHA
    b8467eb View commit details
    Browse the repository at this point in the history

Commits on May 14, 2024

  1. fix to reflect change of rates after running results

    @purav-parekh
    purav-parekh committed May 14, 2024
    Configuration menu
    Copy the full SHA
    ce09007 View commit details
    Browse the repository at this point in the history

  2. empty cell values are replaced with 0 before sending to e3

    @purav-parekh
    purav-parekh committed May 14, 2024
    Configuration menu
    Copy the full SHA
    01e317f View commit details
    Browse the repository at this point in the history

Commits on May 20, 2024

  1. handle -ve IRR in UI

    @purav-parekh
    purav-parekh committed May 20, 2024
    Configuration menu
    Copy the full SHA
    7e9d433 View commit details
    Browse the repository at this point in the history

  2. irr defaults to NA for base case

    @purav-parekh
    purav-parekh committed May 20, 2024
    Configuration menu
    Copy the full SHA
    cd55bbe View commit details
    Browse the repository at this point in the history