Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: add support for https with draft mode #65858

Draft
wants to merge 1 commit into
base: canary
Choose a base branch
from
Draft

wip: add support for https with draft mode #65858

wants to merge 1 commit into from

Conversation

styfle
Copy link
Member

@styfle styfle commented May 16, 2024 •
edited

Work in progress

This adds support for https when using draft mode so the cookie can use the correct value of Secure and SameSite.

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens will be requested when the pull request is marked ready for review timneutkens is a code owner

@ijjk ijjk Awaiting requested review from ijjk ijjk will be requested when the pull request is marked ready for review ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding will be requested when the pull request is marked ready for review shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi will be requested when the pull request is marked ready for review huozhi is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim will be requested when the pull request is marked ready for review feedthejim is a code owner

@ztanner ztanner Awaiting requested review from ztanner ztanner will be requested when the pull request is marked ready for review ztanner is a code owner

@wyattjoh wyattjoh Awaiting requested review from wyattjoh wyattjoh will be requested when the pull request is marked ready for review wyattjoh is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DraftMode __prerender_bypass cookie SameSite LAX instead of None
2 participants
@styfle @ijjk