Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

extra tests for the tie break merge option #419

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

extra tests for the tie break merge option #419

wants to merge 2 commits into from

Conversation

tantaman
Copy link
Collaborator

No description provided.

@tantaman
Copy link
Collaborator Author

tantaman commented Jan 6, 2024

@jeromegn - the db version seems to keep moving forward even when the merge is a no-op.

aa9a9b0

db1 version goes from 2 to 3. It shouldn't move in the second print.

@jeromegn
Copy link
Contributor

jeromegn commented Jan 6, 2024 •
edited

Hmm, what could that be? Is the site_id comparison always true in the new logic?

@jeromegn
Copy link
Contributor

jeromegn commented Jan 9, 2024

Can probably close this one now, fused in #422

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromegn jeromegn jeromegn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tantaman @jeromegn