Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT] increase unit tests for SocketProvider #7042

Draft
wants to merge 9 commits into
base: 4.x
Choose a base branch
from

Conversation

Muhammad-Altabba
Copy link
Contributor

Description

Fixes #7031

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@Muhammad-Altabba Muhammad-Altabba linked an issue May 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented May 15, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 624.38 kB → 624.38 kB (-1 B) -0.00%
Changeset
File Δ Size
../web3-utils/lib/commonjs/converters.js 📈 +961 B (+4.52%) 20.76 kB → 21.7 kB
../web3-utils/lib/commonjs/socket_provider.js 📉 -1 B (-0.01%) 13.69 kB → 13.69 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
web3.min.js 605.08 kB → 605.08 kB (-1 B) -0.00%

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 5b9bb46 Previous: 2f73aa5 Ratio
processingTx 9326 ops/sec (±3.52%) 9204 ops/sec (±3.98%) 0.99
processingContractDeploy 39647 ops/sec (±7.06%) 38039 ops/sec (±7.10%) 0.96
processingContractMethodSend 19358 ops/sec (±6.80%) 19205 ops/sec (±6.35%) 0.99
processingContractMethodCall 38927 ops/sec (±5.54%) 40094 ops/sec (±5.17%) 1.03
abiEncode 44293 ops/sec (±6.75%) 43919 ops/sec (±6.46%) 0.99
abiDecode 29990 ops/sec (±7.06%) 29754 ops/sec (±7.79%) 0.99
sign 1554 ops/sec (±0.77%) 1568 ops/sec (±0.52%) 1.01
verify 371 ops/sec (±0.76%) 372 ops/sec (±0.68%) 1.00

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.28%. Comparing base (2f73aa5) to head (5b9bb46).

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7042      +/-   ##
==========================================
+ Coverage   91.97%   93.28%   +1.30%     
==========================================
  Files         215      215              
  Lines        8291     8291              
  Branches     2277     2277              
==========================================
+ Hits         7626     7734     +108     
+ Misses        665      557     -108     
Flag Coverage Δ
UnitTests 93.28% <100.00%> (+1.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase testing coverage - web3-utils
1 participant