-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DRAFT] increase unit tests for SocketProvider #7042
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller
Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 5b9bb46 | Previous: 2f73aa5 | Ratio |
---|---|---|---|
processingTx |
9326 ops/sec (±3.52% ) |
9204 ops/sec (±3.98% ) |
0.99 |
processingContractDeploy |
39647 ops/sec (±7.06% ) |
38039 ops/sec (±7.10% ) |
0.96 |
processingContractMethodSend |
19358 ops/sec (±6.80% ) |
19205 ops/sec (±6.35% ) |
0.99 |
processingContractMethodCall |
38927 ops/sec (±5.54% ) |
40094 ops/sec (±5.17% ) |
1.03 |
abiEncode |
44293 ops/sec (±6.75% ) |
43919 ops/sec (±6.46% ) |
0.99 |
abiDecode |
29990 ops/sec (±7.06% ) |
29754 ops/sec (±7.79% ) |
0.99 |
sign |
1554 ops/sec (±0.77% ) |
1568 ops/sec (±0.52% ) |
1.01 |
verify |
371 ops/sec (±0.76% ) |
372 ops/sec (±0.68% ) |
1.00 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7042 +/- ##
==========================================
+ Coverage 91.97% 93.28% +1.30%
==========================================
Files 215 215
Lines 8291 8291
Branches 2277 2277
==========================================
+ Hits 7626 7734 +108
+ Misses 665 557 -108
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Description
Fixes #7031
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.