Headless Pages #2621
Open
Headless Pages #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/app-headless-cms/src/HeadlessCMS.tsx
brunozoric
reviewed
Sep 13, 2022
brunozoric
reviewed
Sep 13, 2022
brunozoric
reviewed
Sep 13, 2022
brunozoric
reviewed
Sep 13, 2022
brunozoric
requested changes
Sep 14, 2022
...ages/app-headless-cms/src/modules/pageTemplates/views/editor/EditorPlugins/SidebarPlugin.tsx
Outdated
Show resolved
Hide resolved
packages/app-headless-cms/src/modules/pageTemplates/views/editor/EditorPlugins/index.tsx
Outdated
Show resolved
Hide resolved
packages/app-headless-cms/src/modules/pageTemplates/views/editor/ModelFieldPlugins.tsx
Outdated
Show resolved
Hide resolved
| } | ||
| }) | ||
| }, | ||
| tags: ["content-model", ...(model.tags || [])] |
There was a problem hiding this comment.
Tag here is content-model and I saw in some other places type:contentModel. I assume the difference is due to one being model and other a field...? Maybe use the camel case in both cases?
There was a problem hiding this comment.
Yeah good catch. That content-model is a left-over. Tags will be pulled in from model.tags exclusively, so I'll remove this.
packages/app-headless-cms/src/modules/pageTemplates/views/editor/PageTemplateEditor.tsx
Show resolved
Hide resolved
packages/app-headless-cms/src/modules/pageTemplates/views/list/CloneContentModelDialog.tsx
Show resolved
Hide resolved
packages/app-headless-cms/src/modules/pageTemplates/views/list/CloneContentModelDialog.tsx
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR introduces tagging of content models and model fields, and adds a "page template" list view. This serves as a starting point to develop a dedicated "Page Template Editor" and Headless Pages functionality. Since page templates are still content models at its core, tags are the simplest way to differentiate between various types of content models.
From the API perspective, we're still using the same
listContentModelsquery, but we're filtering models on the client side, to render type specific UI. However, from the GraphQL schema standpoint, all models are processed the same way, and their respective schemas are generated using the same underlying logic.I'll use this PR as an umbrella PR for all further tasks.