You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are numerous instances of panic in the codebase, which are not ideal for production use cases. This often results in crashes of the processes on our production machines because we accept dynamic documents from users, which might contain malformed data. I believe that returning errors instead of panicking would be a better approach.
For instance, the following line has been causing panics in our production instance:
@zignis we're at the process of removing panics. However the ones that usually remained points to potentially bugs or configuration issues. The fact that you've run into this error most likely points to one of these issues. Do you have any reproducible scenario that could help us fix it?
@Horusiath This happened randomly with one of our users, and I cannot provide their document due to obvious reasons. I am trying to reproduce it from a new document, and I'll get back to you if I succeed.
@Horusiath I have the same issues but I don't how to reproduce them. It happened when i try to call txn.encode_state_as_update_v1(&StateVector::default())
There are numerous instances of panic in the codebase, which are not ideal for production use cases. This often results in crashes of the processes on our production machines because we accept dynamic documents from users, which might contain malformed data. I believe that returning errors instead of panicking would be a better approach.
For instance, the following line has been causing panics in our production instance:
y-crdt/yrs/src/slice.rs
Line 239 in 567f83d
We cannot always verify whether the incoming data from the client is correct.
I'm ready to work on this if you give me some hints about your preferred approach.
The text was updated successfully, but these errors were encountered: