Nf floats #1011
Open
Nf floats #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed float instance check from encode_it function
alexbarros
reviewed
Aug 24, 2022
Comment on lines
+7
to
+10
| # Comment this function to see Warnings in console | ||
| def warn(*args, **kwargs): | ||
| pass | ||
| warnings.warn = warn |
There was a problem hiding this comment.
A feature to disable warnings is desirable, but it should not be enabled/disabled by commenting code, also the default should be having the warnings enabled.
alexbarros
reviewed
Aug 24, 2022
Comment on lines
+192
to
+207
| class JsonNonFiniteEncoding(Enum): | ||
| # Use the default python behaviour, which violates the official JSON standard, basically allow_nan = False | ||
| __default = 0 | ||
| # Encode non-finite numbers as null values, allow_nan = True | ||
| __num_null = 1 | ||
| # Encode non-finite floats as null values, allow_nan = True | ||
| __float_null = 2 | ||
|
|
||
| def fetch_python(self): | ||
| return self.__default | ||
|
|
||
| def fetch_null_values(self): | ||
| return self.__num_null | ||
|
|
||
| def fetch_float_values(self): | ||
| return self.__float_null |
There was a problem hiding this comment.
I believe Lukas' version is a bit more clear in this part. Can you help me understand why we would want private fields instead of Lukas' version?
alexbarros
reviewed
Aug 24, 2022
| class PandasSettings(Settings): | ||
| pass | ||
|
|
||
| class SparkSettings(Settings): |
There was a problem hiding this comment.
I believe this would make more sense in the spark-branch
alexbarros
reviewed
Aug 24, 2022
Comment on lines
+4
to
+8
| df = pd.DataFrame([1, 1, np.nan], columns=["a"]) | ||
|
|
||
| profile = ProfileReport(df, title="Pandas Profiling Report", minimal=True) | ||
|
|
||
| print(profile.to_json()) |
There was a problem hiding this comment.
we should validate the expected behavior for each encoding
alexbarros
requested changes
Aug 24, 2022
|
@Vamp1899 can you please update your commit message as well with the correct and expected format? |
portellaa
force-pushed
the
develop
branch
3 times, most recently
from
41d376f
to
5f17cfd
Compare
vascoalramos
force-pushed
the
develop
branch
5 times, most recently
from
a4724cf
to
47d3aeb
Compare
vascoalramos
force-pushed
the
develop
branch
from
45b1d80
to
a0dddb9
Compare
vascoalramos
force-pushed
the
develop
branch
from
e786ac6
to
2d55f32
Compare
vascoalramos
force-pushed
the
develop
branch
2 times, most recently
from
6ba2217
to
ef023c3
Compare
aquemy
force-pushed
the
develop
branch
2 times, most recently
from
4500563
to
cfb020d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is the same issue as mentioned by Lukas but there's a change in code structure by keeping privacy of variables in consideration with regards to more upcoming development .
Pointers -
Handles NaN values in Json as
Python native type - which generates error
Float Null type (Nan , infinity) - Passed as a string in final JSON
Null type - Which modifies values as null in JSON more like allow_nan = True in json python package