Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated 179 broken links #1281

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Conversation

k3agan
Copy link

@k3agan k3agan commented Mar 10, 2023

yamw

@fabclmnt fabclmnt linked an issue Mar 13, 2023 that may be closed by this pull request
3 tasks
@fabclmnt
Copy link
Contributor

Hi @k3agan,

thank you for the help with the links update!

@fabclmnt
Copy link
Contributor

fabclmnt commented Mar 16, 2023

Hi @k3agan ,
your commit message is not following the linter format. May I ask you to update it so we can merge your PR?

@k3agan
Copy link
Author

k3agan commented Mar 17, 2023 via email

@k3agan
Copy link
Author

k3agan commented Mar 17, 2023

Just refreshed my branch, I can do it!

Sorry still new at this 😃

@k3agan
Copy link
Author

k3agan commented Mar 18, 2023

Hi @fabclmnt ,

I've just pushed the new commit that addresses the linting issues you pointed out. Apologies for any confusion my previous commit may have caused, and I appreciate your patience as I continue to learn the ropes. Thank you for your guidance in helping me get this pull request up to par.

I believe the pull request should now be in line with the defined standards. Please let me know if any additional changes are required.

Best regards,

Keagan

@fabclmnt fabclmnt changed the title docs: Updated 179 broken links docs: updated 179 broken links Mar 18, 2023
@k3agan k3agan changed the title docs: updated 179 broken links feat(docs): update broken links in documentation styling Mar 18, 2023
@k3agan k3agan changed the title feat(docs): update broken links in documentation styling chore(docs): update broken links in documentation styling Mar 18, 2023
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (05aaf87) 90.37% compared to head (b0820eb) 90.37%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1281   +/-   ##
========================================
  Coverage    90.37%   90.37%           
========================================
  Files          185      185           
  Lines         5725     5725           
========================================
  Hits          5174     5174           
  Misses         551      551           
Flag Coverage Δ
py3.8-ubuntu-latest-pandas 90.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@k3agan k3agan changed the title chore(docs): update broken links in documentation styling [skip ci] docs: updated 179 broken links Mar 18, 2023
@k3agan
Copy link
Author

k3agan commented Mar 18, 2023

This is a learning moment for me 😆

edit:

All fixed.

So apparently both the commit and the pull request need semantic messages.

@k3agan k3agan changed the title [skip ci] docs: updated 179 broken links docs: updated 179 broken links Mar 18, 2023
@aquemy
Copy link
Contributor

aquemy commented Mar 27, 2023

@k3agan any particular reason to change this link?
image

(don't worry too much about the commit semantic, we're squashing everything)

Copy link
Contributor

@alexbarros alexbarros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the kaggle repo link should be replaced by this one
https://github.com/Kaggle/docker-python/blob/main/Dockerfile.tmpl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

179 Broken Links Found on Docs Pages
7 participants