arch: coding guidelines: use bool param when data nature is boolean #72675
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
area: X86
zephyrbot
requested review from
abrodkin,
andyross,
bbolen,
carlocaione,
ceolin,
dcpleung,
dleach02,
evgeniy-paltsev,
galak,
ithinuel,
MaureenHelm,
microbuilder,
nashif,
ruuddw and
stephanosio
ithinuel
reviewed
May 13, 2024
converted buffer validation param "write" to boolean because this param is used as a boolean. Signed-off-by: Hess Nathan <nhess@baumer.com>
DeHess
force-pushed
the
misra_rules_essential_types_auditable_to_main_arch
branch
from
aa08664
to
c521d23
Compare
|
You're right, updated the doc accordingly |
ruuddw
reviewed
May 13, 2024
| @@ -207,7 +207,7 @@ int arc_core_mpu_get_max_domain_partition_regions(void) | |||
| /** | |||
| * @brief validate the given buffer is user accessible or not | |||
| */ | |||
| int arc_core_mpu_buffer_validate(const void *addr, size_t size, int write) | |||
| int arc_core_mpu_buffer_validate(const void *addr, size_t size, bool write) | |||
There was a problem hiding this comment.
This function calls _is_user_accessible_region, shouldn't that be updated as well?
ithinuel
approved these changes
May 13, 2024
andyross
reviewed
May 13, 2024
@andyross How would I deal with that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
converted arch buffer validation param "write" to boolean because this param is used as a boolean in the method.
This PR is part of the enhancement issue #48002 which port the coding guideline fixes done by BUGSENG on the https://github.com/zephyrproject-rtos/zephyr/tree/v2.7-auditable-branch back to main
The commit in this PR is a subset of the original auditable-branch commit:
d03fa8d