scripts: twister: Fix Unit Tests on Windows systems #72685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukaszMrugala
force-pushed
the
lmrugalx_twister_ut_windows
branch
from
93a04f7
to
5fbed60
Compare
Unit tests currently are not runnable on Windows systems, failing on two testfiles: test_jobserver.py and test_testsuite.py. This commit removes code dependency on Windows-unavailable elements on Windows systems via skipping the offending tests. Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
LukaszMrugala
force-pushed
the
lmrugalx_twister_ut_windows
branch
from
5fbed60
to
902d6c5
Compare
zephyrbot
requested review from
gchwier,
golowanow,
gopiotr,
hakehuang,
KamilxPaszkiet,
nashif and
PerMac
nashif
approved these changes
May 13, 2024
hakehuang
approved these changes
May 14, 2024
KamilxPaszkiet
approved these changes
May 14, 2024
simhein
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests currently are not runnable on Windows systems, failing on two testfiles: test_jobserver.py and test_testsuite.py.
This commit removes code dependency on Windows-unavailable elements on Windows systems via skipping the offending tests.
This step is necessary in order to have Twister on Windows automatic verification.